feat: modernize RatingSampleControl

AvaloniaUI / Avalonia.Samples

Avalonia.Samples aims to provide some minimal samples focusing on a particular issue at a time. This should help getting new users started.

https://www.avaloniaui.net

696 stars 120 forks source link

feat: modernize RatingSampleControl #66

Closed workgroupengineering closed 1 year ago

workgroupengineering commented 1 year ago

What does the pull request do?

Scope of this PR:

[x] fix or update to an existing sample
[ ] add a new sample

What is the current behavior?

Checklist

If this is a new Sample

[ ] Added a ReadMe-file
[ ] Updated the landing page
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with a link to your sample in the related documentation page

In any case

[ ] Spell-checking done
[ ] Checked if all hyperlinks work
[ ] Checked if all images are visible

Fixed issues

workgroupengineering commented 1 year ago

Thx for taking this up 🙏

I'd like to some more explanations about Styles vs ControlThemes. I think this is quite confusing if no link to the docs is present.

I think the information regarding when to use the ControlTheme vs Styles should be relegated to the documentation, the examples should only show best practices.

timunie commented 1 year ago

I think the information regarding when to use the ControlTheme vs Styles should be relegated to the documentation, the examples should only show best practices.

Yeah exactly. In the sample, we just add a link to the docs in that case. Sorry if it was a misunderstanding here. I wanted to have a link to: https://docs.avaloniaui.net/docs/next/basics/user-interface/styling/control-themes

timunie commented 1 year ago

@workgroupengineering im trying it soon.

timunie commented 1 year ago

Looks good to me besides one typo. I'll merge it now as is and add a fix for the typo directly after.

Thank you 🙏