search

AvaloniaUI / Avalonia

Develop Desktop, Embedded, Mobile and WebAssembly apps with C# and XAML. The most popular .NET UI client technology
https://avaloniaui.net
MIT License
25.88k stars 2.24k forks source link

Cannot use `SelectedValueBinding` with items defined in XAML #11220

Closed TomEdwardsEnscape closed 1 year ago

TomEdwardsEnscape commented 1 year ago

Describe the bug The SelectedValue system does not function when a TabControl contains items defined in XAML, through either Items or ItemsSource.

It's common in our WPF codebase to have multiple tab pages and display the one tagged with the value provided by an enum property on the viewmodel. This bug prevents us from replicating that design in Avalonia.

To Reproduce Open samples\ControlCatalog\Pages\TabControlPage.xaml and change the first TabControl (currently line 25) so that it has these property values:

<TabControl SelectedValue="Leaf" SelectedValueBinding="{Binding Header}"

This will not compile due to an error in the compiled binding system:

Unable to resolve property or method of name 'Header' on type 'ControlCatalog.ViewModels.TabControlPageViewModel'.

Switch to ReflectionBinding and you will be able to build, but this exception will be thrown on startup:

System.ArgumentNullException
  HResult=0x80004003
  Message=Value cannot be null. (Parameter 'dataContext')
  Source=Avalonia.Controls
  StackTrace:
   at Avalonia.Controls.Primitives.SelectingItemsControl.BindingHelper.Evaluate(Object dataContext)
   at Avalonia.Controls.Primitives.SelectingItemsControl.OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
   ...

Expected behavior The TabControl starts with the second TabItem (header "Leaf") selected. If SelectedValue changes, so does the active tab.

grokys commented 1 year ago

There are 2 parts to this I think:

  1. Compiled bindings are unable to determine the data type. This is because compiled bindings get their data type from the binding of ItemsSource, but Items is untyped and can contain any data type. This can be fixed by adding x:DataType, i.e.:
<TabControl SelectedValue="Leaf" SelectedValueBinding="{Binding Header}" x:DataType="TabItem">
  1. SelectedItemsControl.BindingHelper.Evaluate doesn't accept a null data context. I think this is a mistake. If one removes this restriction, then everything works as expected. Will open a PR.