search

AvaloniaUI / Avalonia

Develop Desktop, Embedded, Mobile and WebAssembly apps with C# and XAML. The most popular .NET UI client technology
https://avaloniaui.net
MIT License
26.12k stars 2.26k forks source link

Avalonia 12.0 cleanup list #12276

Open kekekeks opened 1 year ago

kekekeks commented 1 year ago

Tracking issue for API changes in the distant future, can be safely ignored until mid-2024

MrJul commented 1 year ago
robloo commented 1 year ago

This is a possibility

cc @workgroupengineering

maxkatz6 commented 11 months ago

Shape.StrokeDashArray should be of IList type, instead of AvaloniaList. This way we could reduce compositor subscriptions count by checking if stroke dash array implements INotifyCollectionChanged or not.

Right now, having AvaloniaList, code like `StrokeDashArray="10 5" will always require us to subscribe to the list changes.

workgroupengineering commented 11 months ago

Make DevToolsOptions a record and change the property setter in init.

maxkatz6 commented 6 months ago

Ideally, this https://github.com/AvaloniaUI/Avalonia/issues/4443 should be revisited as well. Even better if ContextMenu was removed from the main assembly.

robloo commented 2 months ago

protected virtual string? GetHelpTextCore(); should be protected abstract string? GetHelpTextCore();

See: https://github.com/AvaloniaUI/Avalonia/pull/17030#discussion_r1763462589

maxkatz6 commented 1 week ago

Revisiting PasswordChar to support complex emoji is something worth doing, imo. See https://github.com/AvaloniaUI/Avalonia/discussions/17554. This property should be a string type, not a char type.

workgroupengineering commented 1 week ago

Revisiting PasswordChar to support complex emoji is something worth doing, imo. See https://github.com/AvaloniaUI/Avalonia/discussions/17554. This property should be a string type, not a char type.

I think it should be a rune type

Gillibald commented 1 week ago

Revisiting PasswordChar to support complex emoji is something worth doing, imo. See #17554. This property should be a string type, not a char type.

I think it should be a rune type

Not all emojis can be represented by a single rune (codepoint)

rabbitism commented 1 week ago

Revisiting PasswordChar to support complex emoji is something worth doing, imo. See https://github.com/AvaloniaUI/Avalonia/discussions/17554. This property should be a string type, not a char type.

I think it should be a rune type

should be but its not supported by standard2.0 sadly.

MrJul commented 1 week ago

Also consider changing AccessText.AccessKey from char to string.