Add Remove option to GestureRecognizerCollection

[edgarfgp]

Is your feature request related to a problem? Please describe. While working on Fabulous.Avalonia gesture recognizers, I found that GestureRecognizerCollection uses IReadOnlyCollection<GestureRecognizer> and only exposes Add.

Describe the solution you'd like

• Update GestureRecognizerCollection to inherit from.AvaloniaList< GestureRecognizer>
• Or keep IReadOnlyCollection<GestureRecognizer> and expose a Remove method that will modify the private List<GestureRecognizer>? _recognizers

Describe alternatives you've considered

• Create a type based on GestureRecognizerCollection and use reflection Additional context Fabulous.Avalonia GestureRecognizers PR

[timunie]

@emmauss adding an option to remove a gesture sounds like a valid thing to do to me. What do you think, could we accept a PR introducing this API?

If yes, @edgarfgp a PR would be welcome.

[edgarfgp]

@timunie I would be happy to contribute so I can complete the support of Avalonia in F# Fabulous

[timunie]

I've been talking to the team. In general we would accept a method Remove added to remove a GestureRecognizer. However, we need to make sure the gesture can be removed. If it's currently in use while removing, this would break things. So if you start working on this, keep in mind that you have to check if the Gesture is able to remove first.

Good luck 👍

[edgarfgp]

@timunie I was wondering if there are any issues with the gestures currently. Looking at https://github.com/AvaloniaUI/Avalonia/blob/master/samples/ControlCatalog/Pages/GesturePage.cs I could not trigger any gesture. Thanks in advance :)

[emmauss]

@timunie I was wondering if there are any issues with the gestures currently. Looking at https://github.com/AvaloniaUI/Avalonia/blob/master/samples/ControlCatalog/Pages/GesturePage.cs I could not trigger any gesture. Thanks in advance :)

Some gestures require touch input.