AvaloniaUI / Avalonia

Develop Desktop, Embedded, Mobile and WebAssembly apps with C# and XAML. The most popular .NET UI client technology
https://avaloniaui.net
MIT License
24.13k stars 2.09k forks source link

Propagate Dispose from GlyphTypefaceImpl to dispose SkTypeface #15733

Closed lindexi closed 1 week ago

lindexi commented 2 weeks ago

What does the pull request do?

Disposing the SkTypeface by code that can help the SkTypeface call the sk_refcnt_safe_unref faster.

What is the current behavior?

The SkTypeface will call the sk_refcnt_safe_unref when GC.

What is the updated/expected behavior with this PR?

It will dispose the SkTypeface faster.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

No

Obsoletions / Deprecations

Fixed issues

No

avaloniaui-bot commented 2 weeks ago

You can test this PR using the following package version. 11.2.999-cibuild0048477-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

cla-avalonia commented 2 weeks ago
lindexi commented 2 weeks ago

@cla-avalonia agree

Gillibald commented 1 week ago

It looks like we can't update your branch so we can merge it

lindexi commented 1 week ago

@Gillibald Thank you and I updated my branch.

avaloniaui-bot commented 1 week ago

You can test this PR using the following package version. 11.2.999-cibuild0048582-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]