Fix: respect CanResize on macOS regardless of SystemDecorations - Githubissues

AvaloniaUI / Avalonia

Develop Desktop, Embedded, Mobile and WebAssembly apps with C# and XAML. The most popular .NET UI client technology

https://avaloniaui.net

MIT License

26.11k stars 2.26k forks source link

Fix: respect CanResize on macOS regardless of SystemDecorations #17355

Open BAndysc opened 1 month ago

BAndysc commented 1 month ago

What does the pull request do?

This PR moves NSWindowStyleMaskResizable flag application from SystemDecorationsFull case outside of the switch, so this flag is applied also for other system decorations.

What is the current behavior?

NSWindowStyleMaskResizable is applied only for SystemDecorationsFull. Other decorations make windows not resizable.

What is the updated/expected behavior with this PR?

NSWindowStyleMaskResizable is applied regardless of SystemDecorations, it always follows CanResize property.

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Windows which have decorations set to None or BorderOnly and CanResize=true (default) will now become resizable, which can be unexpected for some people. But this behaviour is expected since CanResize is set to true, isn't it?

Obsoletions / Deprecations

Fixed issues

Fixes #17295

avaloniaui-bot commented 1 month ago

You can test this PR using the following package version. 11.3.999-cibuild0052798-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot commented 1 month ago

You can test this PR using the following package version. 11.3.999-cibuild0052824-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot commented 1 month ago

You can test this PR using the following package version. 11.3.999-cibuild0052826-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot commented 1 month ago

You can test this PR using the following package version. 11.3.999-cibuild0052828-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

avaloniaui-bot commented 1 month ago

You can test this PR using the following package version. 11.3.999-cibuild0052830-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]