search

AvaloniaUI / AvaloniaVSCode

Visual Studio Code Extension for Avalonia UI
https://marketplace.visualstudio.com/items?itemName=AvaloniaTeam.vscode-avalonia
MIT License
103 stars 18 forks source link

feat(vscode-avalonia): prompt users to choose a solution file if workspace contains multiple #104

Closed BinToss closed 8 months ago

BinToss commented 9 months ago

Resolves #101

Note: commented code will not work until tc39/proposal-explicit-resource-management is formally part of ES. The commented code can be compiled with ESNext, but won't run in supported in VSCode <= v1.86.1

prashantvc commented 9 months ago

Can you elaborate how this feature works please? I mean as a avalonia developer how will use this feature

BinToss commented 9 months ago

Currently, if the workspace contains several Solution files, the extension selects the first one it finds (SolutionA) and passes it to the SolutionParser. There's a chance SolutionA does not have any WinExe projects by design. However, a WinExe project may exist in SolutionB, SolutionC, et cetera.

This change allows the user to choose which Solution file should be passed to SolutionParser.

On that note, perhaps every solution file should be parsed and filtered for Solutions which include the current document. Only then should the user be prompted.

prashantvc commented 9 months ago

Sounds goo. Could you fix the review comments? I will merge once you do it :)

BinToss commented 8 months ago

I don't see any review comments to resolve.

BinToss commented 8 months ago

I accidentally deleted the wrong branch and I'm unable to re-open the pull request. I have to create a new one...