search

AvaloniaUI / avalonia-dotnet-templates

Avalonia Templates for `dotnet new`
MIT License
491 stars 84 forks source link

Remove ReactiveUI from XPlat templates #252

Closed maxkatz6 closed 2 months ago

maxkatz6 commented 6 months ago

Is your feature request related to a problem? Please describe.

^

Describe the solution you'd like

Personally, I would go with no MVVM framework at all. Possibly just keep ViewModelBase with minimal INotifyPropertyChanged impl and link to our documentation explaining other possibilities

Describe alternatives you've considered

No response

Additional context

No response

stevemonaco commented 5 months ago

I understand the desire to be more like WPF that only offers the blankest of canvases, but that's pretty inconvenient for end developers. I would probably not use avalonia-dotnet-templates anymore and would either: 1. create my own template or 2. find a third-party template provider. I frequently create new Avalonia projects to experiment/verify and the 3-5 minute savings per project with Mvvm Toolkit out-of-the-box does add up. Once I get invested in reinventing part of the wheel, I'm probably reinventing the entire wheel.

Mrxx99 commented 5 months ago

What about having no mvvm by default in xplat template, but an option (--usemvvm) to include Community toolkit MVVM?

stevemonaco commented 5 months ago

If the template option still generates and wires a basic Mvvm Toolkit app similar to today, then that's sufficient.

maxkatz6 commented 5 months ago

Having an additional option parameter makes sense, yes. Even though It makes templates more complex.

maxkatz6 commented 2 months ago

It's not optional https://github.com/AvaloniaUI/avalonia-dotnet-templates/pull/256