search

AvaloniaUtils / DialogHost.Avalonia

AvaloniaUI control that provides a simple way to display a dialog with information or prompt the user when information is needed
MIT License
228 stars 15 forks source link

Popup focus issues #7

Closed danipen closed 2 years ago

danipen commented 2 years ago

I found a couple of issues:

  1. The focus is drawn with some unwanted offset.
  2. The focus should be restricted to the Popup.

https://user-images.githubusercontent.com/501613/162749424-1672cd29-0aae-4a4a-965d-00d0e3f0f69a.mp4

If someone gives me some clues about how to fix it, I can try to create a PR.

danipen commented 2 years ago

@SKProCH any ideas?

SKProCH commented 2 years ago

Hmm, this is strange. Can you provide project for testing?

danipen commented 2 years ago

@SKProCH the issue happens always. This example reproduces the issue.bhttps://github.com/danipen/SlowAnimationMinimalApp

SKProCH commented 2 years ago

@danipen Ok, thanks. Ill try to look. In case if you want to try fix it by youself, I think what problem can be solved using FocusManager or something like that in Avalonia

danipen commented 2 years ago

I took a look and I was unable to find the issue. 😔

danipen commented 2 years ago

Hey @SKProCH something new about his?

SKProCH commented 2 years ago

Not yet. I could not find a quick solution, and could not spend more time because of work. I will try this weekend to figure it out and fix it.

SKProCH commented 2 years ago

@danipen you can install version v0.5.0-rc0 from nuget now. It should fix your issue. If not - feel free to reopen it.

danipen commented 2 years ago

Thank you very much for taking a look. I'm out now I'll return next Thursday. I'll take a look then.

SKProCH commented 2 years ago

Hello, @danipen Were you able to check this bug?

danipen commented 2 years ago

Hi, @SKProCH sorry for the delay.

YES! The changes worked like a charm, all is working as expected now. Thanks!