search

Avamander / arduino-tvout

Arduino-TVout
332 stars 82 forks source link

Fix memory corruption in shift method #105

Closed starling13 closed 2 years ago

Avamander commented 6 years ago

Can't confirm this is a proper fix. Can you explain a bit more what you've fixed?

TomasRoj commented 5 years ago

looks like he forgot password to his account xdd

abcbarryn commented 5 years ago

Hopefully he can reset his password and explain. I agree it would be good to better understand what the issue is this is supposed to fix before applying this update.

TomasRoj commented 5 years ago

Yes tottaly agree but you know. People...

starling13 commented 3 years ago

Hello, I beg your pardon for such a stupid situation. I forget my PR and don't watch the discussion and it's status for years. I found some memory corruption while working on my project of Terminal-BASIC arduino-mega based diy computer https://hackaday.io/project/21588-basic-microcomputer-based-on-arduino.

I'v forked the library on bitbucket https://bitbucket.org/terminalbasicteam/libtvoutex/src/master/ Then I write an SDL2 emulator, which uses TvOut drawing functions but draws the frame buffer on SDL window. I'v found some errors that way and fix them (probably).