search

Avamander / arduino-tvout

Arduino-TVout
325 stars 81 forks source link

I have some fixes for TVOut #112

Closed spaceneedle closed 5 years ago

spaceneedle commented 6 years ago

Hello, i tried to email avamander, but it bounced.

As you may or may not know, TVOut is broken these days in the latest Arduino release due to an issue the way assembler macros are handled by the compiler. The hilarious thing is that pops up intermittently depending on what TVOut functions are placed next to what. This is the famous "opcode error" that spews out while compiling. I have a fix for it, but I am wondering if you can add me as a contributor and create a "development" branch so we can get this fix out?

I also have a fix for pollserial, which is also broken in the current release. It also improves screen stability while using pollserial. (apparently screen instability popped up a few Arduino releases ago as well).

Lastly, the fonts are a bit of an issue, but I see that there is a pull request for this.

Avamander commented 6 years ago

Not sure what e-mail you got... But anyways, if you have fixes, submit a pull request.

spaceneedle commented 6 years ago

Looks like i typoed it .. i'll submit a pull request later today when I get home. Thanks!

patrickweaver commented 6 years ago

@spaceneedle Did these changes ever get merged in?

johnbentcope commented 6 years ago

@PatrickWeaver It looks like they have not. Last commit was April 2017, @spaceneedle posted this in December 2017.

zoomx commented 6 years ago

It seems that there isn't any pull request by spaceneedle

tomsykes commented 6 years ago

Hi @spaceneedle - if you could share your changes, I can help you submit a pull request, or do it for you.

patrickweaver commented 6 years ago

Are people still having the problem with TVOut not working at all? Recently when I've used it I have been able to use the most recent version of the Arduino IDE (1.8.5), but I might just not be remembering something more complex that I was doing when I first ran into this bug.

tomsykes commented 6 years ago

I am, but I admit I'm using 1.6.12. I'll try updating, but the problem is rather random in its nature.

Godfear17 commented 5 years ago

cannot get it to work in 1.8.5...

Avamander commented 5 years ago

@Godfear17 https://github.com/Avamander/arduino-tvout/issues/106#issuecomment-328036536

spaceneedle commented 4 years ago

Hey guys. I have picked up my TVOut project again and i just noticed this. I feel bad abandoning everyone. I have the fix ready for everyone, but for whatever reason, github is not allowing me to submit a pull request to this repo. This library makes use of some assembly macros that break due to something really stupid (I can't remember what triggers it, but it seems that once you get a good project going, it effectively has issues). @Avamander I will send you an email directly with this fix.

Also, I noticed some issues with the fonts and the examples. It seems like the Arduino IDE can't find them. Either the include is not doing a full search or something else is an issue. Moving them to the root directory fixed the issue.

As I mentioned earlier regarding my project, I am launching a TVOut kit complete with cart slot and two atari compatible joystick ports in September 2019. The main board is game capable, but when a cart is inserted, it relinquishes the video output to the cartridge and relays game controller input (both digital and analog atari joysticks) via serial. Should be a lot of fun!