Avamander / arduino-tvout

Arduino-TVout
325 stars 81 forks source link

a font bug need fix or notice #138

Open L1uTongwei opened 1 year ago

L1uTongwei commented 1 year ago

In font files, i found this:

//[
0b11000000,
0b10000000,
0b10000000,
0b10000000,
0b11000000,
0b00000000,
0,              //for the life of me I have no idea why this is needed....
//\
0b10000000,
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,

If you use //\, it will let the comment extend to the next line, so it is useless for the line of 0b10000000,.

So in fact the charcacter '\' is:

0
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,

It's a bug.

L1uTongwei commented 1 year ago

In file font4x6.cpp.

L1uTongwei commented 1 year ago

I fixed it with

//[
0b11000000,
0b10000000,
0b10000000,
0b10000000,
0b11000000,
0b00000000,
//(backslash)
0b10000000,
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,
L1uTongwei commented 1 year ago

@Avamander

L1uTongwei commented 1 year ago

Well, if you open -Wall & -Wextra, you'll get:

thirdparty/TVout/TVoutfonts/font4x6.cpp:426:1: warning: multi-line comment [-Wcomment]
 //\
 ^
ghost commented 1 year ago

I remember I found same bug on the code.

did you made font the size is not the multiple of 8?

I wanted to make 11x11 font but it was very difficult.

8 or 16 font was easy to made

L1uTongwei commented 1 year ago

I remember I found same bug on the code.

did you made font the size is not the multiple of 8?

I wanted to make 11x11 font but it was very difficult.

8 or 16 font was easy to made

Well, if the size is not the multple of 8, it will be very diffcult to make font allign on the screen.

And the code are running base on the multiple of 8. The wide of the screen is multiple of 8.

So That's diffcult. I just want to notice everyone there's a clearly bug on the font.

L1uTongwei commented 1 year ago

@orangefabri If you are interested in the code, why not join the develop?