AvarionMC / graves

GNU General Public License v3.0
15 stars 3 forks source link

please support AdvancedSlimePaper #18

Open inrhor opened 1 month ago

inrhor commented 1 month ago

World unloading and loading should be considered

https://github.com/InfernalSuite/AdvancedSlimePaper

svaningelgem commented 1 month ago

If ASP can load spigot plugins, this should work fine. Could you tell me what error it gives otherwise?

I'm inclined not to put efforts into it, but I would welcome any PR you have to add in its support.

inrhor commented 1 month ago

It can be loaded, but if you unload the world and reload the world, the world will become a new instance, and grave will not run in the reloaded world. There is no commented code and there is nothing I can do to fix and PR

svaningelgem commented 1 month ago

It can be loaded, but if you unload the world and reload the world, the world will become a new instance, and grave will not run in the reloaded world. I'm thinking this might be because of the way that graves are stored in its own database.

There is no commented code and there is nothing I can do to fix and PR This sentence I don't understand. But I'm wondering how you would want to add support for this if there is nothing to fix :).

I can give you some pointers from the quick cursory look I took:

Just some ideas for you to get started on it.

Hope they help.