Found the real source of the issue and fixed it properly.
The changed block of code is responsible for updating the compass when the compass is interacted with, it does this by blindly overwriting the item in the held item slot, assuming that it's still the compass. Since so many things are happening in this one listener, it's pretty common that the held item has already been modified due to the grave being auto-looted by the time the compass is being updated, so I just added a check that the currently held item is still the same item used to fire the PlayerInteractEvent, which has properly solved the issue and still allows the compass to be updated in the case that anything about the connected grave has changed.
svaningelgem
commented
5 months ago
Found the real source of the issue and fixed it properly. The changed block of code is responsible for updating the compass when the compass is interacted with, it does this by blindly overwriting the item in the held item slot, assuming that it's still the compass. Since so many things are happening in this one listener, it's pretty common that the held item has already been modified due to the grave being auto-looted by the time the compass is being updated, so I just added a check that the currently held item is still the same item used to fire the
PlayerInteractEvent, which has properly solved the issue and still allows the compass to be updated in the case that anything about the connected grave has changed.