AvatarHurden / keypirinha-currency

A currency converter plugin for Keypirinha
MIT License
30 stars 4 forks source link

Lost copy result to clipboard functionality #9

Closed DrorHarari closed 5 years ago

DrorHarari commented 5 years ago

When I enter a number and currency like "12 USD" I get a list of currencies and the value of 12 USD in those currencies:

image

I expect to be able to move to one of them and hit Enter to copy the numeric value to the clipboard but it does not work. Here I moved to the Euros and hit Enter (same with Tab) and I got:

image

Here I can press Enter or Tab or whatever but I stay in the same place and the value is not copied, as expected, to the clipboard.

AvatarHurden commented 5 years ago

Hi @DrorHarari

This should be fixed in the newer version. I also added a new option to copy the whole conversion as an equation, showing the sources and result together.

Let me know if there are any other issues!

DrorHarari commented 5 years ago

Hi Arthur. Thanks for the quick fix - it is almost perfect 😎

What would make it perfect is to allow me to decide what would be copied on the default suggestion I get when typing (for example) "12 USD". Now what's copied (if I'm positioned on the Euro) is "10.61 EUR" which is not so helpful in Excel or in Calc (true, I don't use it but as an example). The menu after the tab let me choose if to copy with or without the unit.

One good option is to have it a configurable option, maybe add a config option CopyActionPreference with possible values like: CopyNumber / CopyNumberAndUnit / CopyConversion / CopyLast (the CopyLast makes my last specific selection sticky).

Anyway, thanks. /d