Add extra date format and test for date handling

AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.

Other

1.48k stars 198 forks source link

Add extra date format and test for date handling #125

Closed Sherlouk closed 3 years ago

Sherlouk commented 3 years ago

Closes #124

Hey 👋

Starting to experiment with this lib in a project of mine - so a couple small fixes coming in 🙌 First one handles yet another date format we were seeing errors for.

Thanks 😄

SwiftLeeBot commented 3 years ago

	Messages
:book:	View more details on Bitrise
:book:	AppStoreConnect-Swift-SDK: Executed 161 tests, with 0 failures (0 unexpected) in 0.474 (1.116) seconds

AppStoreConnect_Swift_SDK.framework: Coverage: 81.22

File	Coverage
APIProvider.swift	86.72%	✅

AppStoreConnect-Swift-SDKTests.xctest: Coverage: 99.61

File	Coverage
APIProviderTests.swift	97.73%	✅

Generated by :no_entry_sign: Danger Swift against d37c70b568b574214ff0d16107c7842a4bf48374

Sherlouk commented 3 years ago

Have hopefully normalised the DateFormatter enough now that it should work on CI too. I've also fixed one of the warnings -- it's unrelated to my work but was an easy fix 😄

SwiftLeeBot commented 3 years ago

Congratulations! :tada: This was released as part of Release 1.3.0 :rocket:

Generated by GitBuddy