Make BuildBundleFileSize.links optional

AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.

Other

1.48k stars 198 forks source link

Make BuildBundleFileSize.links optional #168

Closed marcelofabri closed 2 years ago

marcelofabri commented 2 years ago

We saw this not being returned in the API:

Error: keyNotFound(CodingKeys(stringValue: "links", intValue: nil), Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "data", intValue: nil), _JSONKey(stringValue: "Index 0", intValue: 0)], debugDescription: "No value associated with key CodingKeys(stringValue: \"links\", intValue: nil) (\"links\").", underlyingError: nil)).

It's been fixed on Apple's side, but figured out we might as well treat it as optional to future-proof it.

AvdLee commented 2 years ago

Makes total sense, thanks for your contribution!

SwiftLeeBot commented 2 years ago

	Messages
:book:	View more details on Bitrise
:book:	No tests found for the current changes in build/reports

Generated by :no_entry_sign: Danger Swift against 591ecca53f46c71233080a3086efd72dbbc18ba0