search

AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.
Other
1.48k stars 198 forks source link

Update types to automatically conform to `Identifiable` where possible #192

Closed liamnichols closed 2 years ago

liamnichols commented 2 years ago

New in CreateAPI 0.0.5 is the isGeneratingIdentifiableConformance option (false by default).

I spotted that the example used a List but had to manually specify the \.id key path. This can be avoided if we start generating entities with Identifiable conformance out of the box.

In this PR, I enable the flag, regenerate the entities and update the example. What do you think?

SwiftLeeBot commented 2 years ago
Warnings
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/PromotedPurchase.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/BundleID.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppClipDefaultExperience.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/ReviewSubmissionItemCreateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppScreenshotSet.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/CiWorkflow.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppCustomProductPageCreateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/CiProduct.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/Profile.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppClipAdvancedExperienceCreateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/SubscriptionIntroductoryOffer.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/ReviewSubmissionItem.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/Subscription.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppPricePointV2.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/CiWorkflowCreateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/ReviewSubmission.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/SubscriptionOfferCode.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/BuildBundle.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppClipAdvancedExperienceUpdateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppStoreVersionExperimentTreatmentLocalization.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/BetaGroup.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppInfoUpdateRequest.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/CiBuildRun.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppStoreVersionLocalization.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppCustomProductPageLocalization.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/Build.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppClipAdvancedExperience.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppStoreVersion.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/InAppPurchaseV2.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppEventLocalization.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppPreviewSet.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/App.swift, which is over 300 lines big.
:warning: Consider to place some `MARK:` lines for Sources/OpenAPI/Entities/AppInfo.swift, which is over 300 lines big.
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'AppPricePoint' is deprecated: Deprecated
:warning: 'PricePoints' is deprecated: Deprecated
:warning: 'PricePoints' is deprecated: Deprecated
:warning: 'PricePoints' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
Messages
:book: View more details on Bitrise
:book: AppStoreConnect-Swift-SDK-Tests: Executed 9 tests (0 failed, 0 retried, 0 skipped) in 0.121 seconds

SwiftLint found issues

Severity File Reason
Warning AppsListView.swift:54 Line should be 140 characters or less: currently 151 characters (line_length)
Warning AppsListView.swift:56 Line should be 140 characters or less: currently 151 characters (line_length)

Code Coverage Report

Name Coverage

Generated by :no_entry_sign: Danger Swift against ac6478d6033c73494e984909666892ceb2db826c

SwiftLeeBot commented 2 years ago

Congratulations! :tada: This was released as part of Release 2.3.0 :rocket:

Generated by GitBuddy