AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.
Other
1.48k stars 198 forks source link

Added tvOS as Target #217

Closed karm435 closed 1 year ago

karm435 commented 1 year ago

Added tvOS as Target in package.swift

Related to issue: https://github.com/AvdLee/appstoreconnect-swift-sdk/issues/216

SwiftLeeBot commented 1 year ago
Fails
:no_entry_sign: `danger-swift` failed.

Log

/var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/danger-response.json


Generated by :no_entry_sign: dangerJS against b7b27071d666b95160544863931cd8a7e1df27bf

AvdLee commented 1 year ago

@karm435 do the tests succeed locally? CI is currently broken, so I need some time to fix that

karm435 commented 1 year ago

😞 looks like it did not run tests locally. I will run them and see if I could fix them.

On Tue, 13 Dec 2022 at 8:23 pm, Antoine van der Lee < @.***> wrote:

@karm435 https://github.com/karm435 do the tests succeed locally? CI is currently broken, so I need some time to fix that

— Reply to this email directly, view it on GitHub https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/217#issuecomment-1348140327, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS47YTK34EMESQVIJ6NJ3TWNBFANANCNFSM6AAAAAASXM322Y . You are receiving this because you were mentioned.Message ID: @.***>

karm435 commented 1 year ago

I ran the tests locally and looks like that are fine.

image
AvdLee commented 1 year ago

@karm435 they completed, but did the succeed as well?

karm435 commented 1 year ago

@karm435 they completed, but did the succeed as well?

They are completed with Green color

image
AvdLee commented 1 year ago

Thanks for your contribution @karm435

karm435 commented 1 year ago

You are welcome. I will see what else I can contribute to as I develop my app.