search

AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.
Other
1.48k stars 198 forks source link

Added “DEVELOPER_ID_APPLICATION_G2” to certificate enums #266

Closed Workshed closed 7 months ago

Workshed commented 7 months ago

This means that when the code is generated we cover cases which Apple is returning but are not published in their OpenAPI spec as yet. This will resolve issue #252

MortenGregersen commented 7 months ago

Please duplicate feedback, FB13701181, to Apple: https://github.com/MortenGregersen/Bagbutik?tab=readme-ov-file#fb13701181-app-store-connect-api-spec-is-missing-developer_id_application_g2-type-for-the-certificate-type-schema

Workshed commented 7 months ago

I've submitted FB13704959 which duplicates your issue @MortenGregersen

SwiftLeeBot commented 7 months ago
Warnings
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
:warning: 'Builds' is deprecated: Deprecated
:warning: 'Builds' is deprecated: Deprecated
:warning: 'AppPreOrder' is deprecated: Deprecated
:warning: 'AppPrice' is deprecated: Deprecated
:warning: 'InAppPurchase' is deprecated: Deprecated
:warning: 'GameCenterEnabledVersion' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'AppPreOrder' is deprecated: Deprecated
:warning: 'AppPrice' is deprecated: Deprecated
:warning: 'InAppPurchase' is deprecated: Deprecated
:warning: 'GameCenterEnabledVersion' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'Builds' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionSubmission' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'AppPreOrder' is deprecated: Deprecated
:warning: 'AppPrice' is deprecated: Deprecated
:warning: 'InAppPurchase' is deprecated: Deprecated
:warning: 'GameCenterEnabledVersion' is deprecated: Deprecated
:warning: 'Prices' is deprecated: Deprecated
:warning: 'AvailableTerritories' is deprecated: Deprecated
:warning: 'InAppPurchases' is deprecated: Deprecated
:warning: 'AgeRatingDeclaration' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppStoreVersionExperiment' is deprecated: Deprecated
:warning: 'AppPreOrder' is deprecated: Deprecated
:warning: 'AppPrice' is deprecated: Deprecated
:warning: 'InAppPurchase' is deprecated: Deprecated
:warning: 'GameCenterEnabledVersion' is deprecated: Deprecated
Messages
:book: AppStoreConnect-Swift-SDK-Tests: Executed 17 tests (0 failed, 0 retried, 0 skipped) in 0.151 seconds
:book: View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Error PathsV1Certificates.swift:66 Line should be 160 characters or less; currently it has 260 characters (line_length)
Warning PathsV1Certificates.swift:8 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)

Generated by :no_entry_sign: Danger Swift against 5e71eda9f85b3241b8ecac6739cbfb0019e327be

Workshed commented 7 months ago

Apple's response to the feedback:

Thank you for your message. Upon further review, we require additional files to help us investigate your feedback. Please reproduce the issue, provide a screen recording, and use Feedback Assistant to gather the requested file.

We appreciate your feedback and looking forward to hear from you.

Workshed commented 6 months ago

Absolute waste of time raising this issue with Apple, their response is Resolution:Investigation complete - Unable to diagnose with current information