artyom-razinov
commented
7 months ago Note: got the "All checks have failed", instantly after creating a PR, maybe a glitch on CI
Closed artyom-razinov closed 7 months ago
artyom-razinov
commented
7 months ago Note: got the "All checks have failed", instantly after creating a PR, maybe a glitch on CI
AvdLee
commented
7 months ago Note: got the "All checks have failed", instantly after creating a PR, maybe a glitch on CI
Running now, I have to manually approve CI runs on Bitrise, unfortunately.
SwiftLeeBot
commented
7 months ago | Warnings | |
|---|---|
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'InAppPurchases' is deprecated: Deprecated |
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'InAppPurchases' is deprecated: Deprecated |
| :warning: | 'Builds' is deprecated: Deprecated |
| :warning: | 'Builds' is deprecated: Deprecated |
| :warning: | 'AppPreOrder' is deprecated: Deprecated |
| :warning: | 'AppPrice' is deprecated: Deprecated |
| :warning: | 'InAppPurchase' is deprecated: Deprecated |
| :warning: | 'GameCenterEnabledVersion' is deprecated: Deprecated |
| :warning: | 'AgeRatingDeclaration' is deprecated: Deprecated |
| :warning: | 'AgeRatingDeclaration' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionSubmission' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionSubmission' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'AppPreOrder' is deprecated: Deprecated |
| :warning: | 'AppPrice' is deprecated: Deprecated |
| :warning: | 'InAppPurchase' is deprecated: Deprecated |
| :warning: | 'GameCenterEnabledVersion' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'Builds' is deprecated: Deprecated |
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'InAppPurchases' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionSubmission' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionSubmission' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'Prices' is deprecated: Deprecated |
| :warning: | 'AvailableTerritories' is deprecated: Deprecated |
| :warning: | 'AppPreOrder' is deprecated: Deprecated |
| :warning: | 'AppPrice' is deprecated: Deprecated |
| :warning: | 'InAppPurchase' is deprecated: Deprecated |
| :warning: | 'GameCenterEnabledVersion' is deprecated: Deprecated |
| :warning: | 'AppPreOrder' is deprecated: Deprecated |
| :warning: | 'AppPrice' is deprecated: Deprecated |
| :warning: | 'InAppPurchase' is deprecated: Deprecated |
| :warning: | 'GameCenterEnabledVersion' is deprecated: Deprecated |
| :warning: | 'AgeRatingDeclaration' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| :warning: | 'AppStoreVersionExperiment' is deprecated: Deprecated |
| Messages | |
|---|---|
| :book: | AppStoreConnect-Swift-SDK-Tests: Executed 17 tests (0 failed, 0 retried, 0 skipped) in 0.126 seconds |
| :book: | View more details on Bitrise |
| Name | Coverage |
|---|
| Severity | File | Reason |
|---|---|---|
| Warning | APIProvider.swift:76 | Use shorthand syntax for optional binding (shorthand_optional_binding) |
| Warning | APIProvider.swift:144 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:250 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:280 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:301 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:318 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:328 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:344 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:357 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:368 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:378 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:386 | Lines should not have trailing whitespace (trailing_whitespace) |
| Warning | APIProvider.swift:106 | Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument) |
Generated by :no_entry_sign: Danger Swift against 2ca8b65a57b1f7109ff9ef52aae9985f5b01908d
There were 2 users (in a certain company where I work, which is a very small fraction of users) who experienced this issue, they had some specific environment, we did not check which environment they had or why this code works, we only know that it solves the issue.
The fix may look bad, since it's the 4th way of parse the date, however, there were already 3 ways of parsing it. The reason I make this PR is that it would be great to not use a fork of this repository in our company.