search

AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.
Other
1.48k stars 198 forks source link

Replace withCheckedThrowingContinuation Calls With withUnsafeThrowingContinuation #288

Open AlexNsbmr opened 1 month ago

AlexNsbmr commented 1 month ago

First, thank you for maintaining this awesome library! 🙏

I wanted to report an issue we’re experiencing when using withCheckedThrowingContinuation on iOS 18, which is causing several crashes in our app. After investigating, it seems like replacing withCheckedThrowingContinuation with withUnsafeThrowingContinuation resolves the issue.

For reference, the team at RevenueCat has implemented a similar fix, and you can check out their approach here: https://github.com/RevenueCat/purchases-ios/pull/4286

Would it be possible to make this update in the library as well?

Thank you for your attention to this issue!

github-actions[bot] commented 1 day ago

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.