Closed krishnasharmak05 closed 3 months ago
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.
@krishnasharmak05 don't change db, revoke it. And you have hashing the password but on during login, you have to verifying the password using hash codes?
If I revoke the database, signups and logins will fail because the hashed passwords (checked against the user’s password field in the database) will be in the format $argon2id$...
, while the database will contain plaintext passwords. What’s the purpose of hashing passwords if they’re stored in plaintext? If you have an alternative idea, @Avdhesh-Varshney , please share it so that I can implement it.
Yes, I’ve implemented and tested code that verifies user passwords during login. It uses hash codes stored in the database.
Closes #11
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
I have done the following:
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
I throughly tested the changes by creating new users, and logging them in (See screenshot below).
Checklist: ☑️
Screenshots 📷
SignUp testing 👇
Login testing 👇