Added Jokes Program using API

Avdhesh-Varshney / Jarvis

Jarvis is an AI-powered application that allows users to control various devices and applications through voice commands, offering tailored services based on user roles.

https://jarvis-ai-assistant.streamlit.app/

MIT License

29 stars 37 forks source link

Added Jokes Program using API #54

Closed imsuraj675 closed 3 months ago

imsuraj675 commented 3 months ago

Closes: #4

Title : Added Jokes Program using API
Name:: Suraj Kashyap
Idenitfy yourself: SSOC

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made I have added the required Jokes program under API programs section

Type of change ☑️

What sort of change have you made:

[x] New feature (non-breaking change which adds functionality)

Checklist: ☑️

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.

github-actions[bot] commented 3 months ago

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

imsuraj675 commented 3 months ago

In this issue, earlier I was trying to add audio effects, but I was unable to do so, when you have set the priority to high, I was forced to submit the work whatever I had done. But now, I found the solution to add sound effects. Here is the video showing the changes, which I want to do. If permitted, will I have to open a new issue or directly raise a new PR indicating this PR.

Till now I have added 10 random laughing/funny sound. The sounds are present inside the assets folder inside a Jokes_Sound directory. All have a duration of around 3-5sec.

https://github.com/Avdhesh-Varshney/Jarvis/assets/120774752/af5dc789-b935-470a-afc7-7d381ddf6945

Avdhesh-Varshney commented 3 months ago

@imsuraj675 idea of sounds looks nice. But these instruments sounds are not looks good for jokes feature. If you want to add, search for something laughing sounds, so that user will motivate to laugh, whatever be the jokes.

assets/sounds/... ok