Aventus-Network-Services / avn-api

An API for interacting with the Aventus AvN layer 2 blockchain
5 stars 1 forks source link

SYS-3543 Group api's in a module and converts them to TS #31

Closed nahuseyoum closed 1 year ago

nahuseyoum commented 1 year ago

Also updates all the api methods to have access to the signerAddress

nahuseyoum commented 1 year ago

return await this.api.nonceCache.incrementNonce(proxy

Minor general comment: we only use "setNonce" to decrement the nonce - would we do better to either update the nonceCache method or add a decrement wrapper to the setNonce even?

We also use setNonce to "reset" the nonce when it expires. I was trying to avoid having 2 functions doing kind of the same thing. But happy to add them too.