AverageAnime / create-food

Create: Food is an add-on for Farmer's Delight based on expanding food content found in Create, Farmer's Delight, and vanilla MC. This mod is designed with compatibility in mind, with various features to help integration with other mods.
https://www.curseforge.com/minecraft/mc-mods/create-food
GNU General Public License v3.0
1 stars 2 forks source link

[Bug] Status effects not applying when being auto-fed Create Food items with the Sophisticated Backpacks Feeding Upgrade #25

Open jonathansharpe opened 1 month ago

jonathansharpe commented 1 month ago

Steps to reproduce:

  1. Obtain a Sophisticated Backpack with a feeding upgrade, and a Create: Food item that applies a status effect
  2. Equip the backpack with the Create: Food item inside
  3. Exhaust enough hunger for the auto-feeding upgrade to feed the player
  4. No status effects are applied, despite the tooltips noting otherwise

Version Information

[13:53:48] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.16.0
[13:53:48] [main/INFO]: Fabric is preparing JARs on first launch, this may take a few seconds...
[13:53:48] [main/INFO]: Loading 93 mods:
    - cloth-config 11.1.118
       \-- cloth-basic-math 0.6.1
    - createfood 1.1.0
    - emi 1.1.10+1.20.1+fabric
    - fabric-api 0.92.2+1.20.1
       |-- fabric-api-base 0.4.31+1802ada577
       |-- fabric-api-lookup-api-v1 1.6.36+1802ada577
       |-- fabric-biome-api-v1 13.0.13+1802ada577
       |-- fabric-block-api-v1 1.0.11+1802ada577
       |-- fabric-block-view-api-v2 1.0.1+1802ada577
       |-- fabric-blockrenderlayer-v1 1.1.41+1802ada577
       |-- fabric-client-tags-api-v1 1.1.2+1802ada577
       |-- fabric-command-api-v1 1.2.34+f71b366f77
       |-- fabric-command-api-v2 2.2.13+1802ada577
       |-- fabric-commands-v0 0.2.51+df3654b377
       |-- fabric-containers-v0 0.1.64+df3654b377
       |-- fabric-content-registries-v0 4.0.11+1802ada577
       |-- fabric-convention-tags-v1 1.5.5+1802ada577
       |-- fabric-crash-report-info-v1 0.2.19+1802ada577
       |-- fabric-data-attachment-api-v1 1.0.0+de0fd6d177
       |-- fabric-data-generation-api-v1 12.3.4+1802ada577
       |-- fabric-dimensions-v1 2.1.54+1802ada577
       |-- fabric-entity-events-v1 1.6.0+1c78457f77
       |-- fabric-events-interaction-v0 0.6.2+1802ada577
       |-- fabric-events-lifecycle-v0 0.2.63+df3654b377
       |-- fabric-game-rule-api-v1 1.0.40+1802ada577
       |-- fabric-item-api-v1 2.1.28+1802ada577
       |-- fabric-item-group-api-v1 4.0.12+1802ada577
       |-- fabric-key-binding-api-v1 1.0.37+1802ada577
       |-- fabric-keybindings-v0 0.2.35+df3654b377
       |-- fabric-lifecycle-events-v1 2.2.22+1802ada577
       |-- fabric-loot-api-v2 1.2.1+1802ada577
       |-- fabric-loot-tables-v1 1.1.45+9e7660c677
       |-- fabric-message-api-v1 5.1.9+1802ada577
       |-- fabric-mining-level-api-v1 2.1.50+1802ada577
       |-- fabric-model-loading-api-v1 1.0.3+1802ada577
       |-- fabric-models-v0 0.4.2+9386d8a777
       |-- fabric-networking-api-v1 1.3.11+1802ada577
       |-- fabric-networking-v0 0.3.51+df3654b377
       |-- fabric-object-builder-api-v1 11.1.3+1802ada577
       |-- fabric-particles-v1 1.1.2+1802ada577
       |-- fabric-recipe-api-v1 1.0.21+1802ada577
       |-- fabric-registry-sync-v0 2.3.3+1802ada577
       |-- fabric-renderer-api-v1 3.2.1+1802ada577
       |-- fabric-renderer-indigo 1.5.2+85287f9f77
       |-- fabric-renderer-registries-v1 3.2.46+df3654b377
       |-- fabric-rendering-data-attachment-v1 0.3.37+92a0d36777
       |-- fabric-rendering-fluids-v1 3.0.28+1802ada577
       |-- fabric-rendering-v0 1.1.49+df3654b377
       |-- fabric-rendering-v1 3.0.8+1802ada577
       |-- fabric-resource-conditions-api-v1 2.3.8+1802ada577
       |-- fabric-resource-loader-v0 0.11.10+1802ada577
       |-- fabric-screen-api-v1 2.0.8+1802ada577
       |-- fabric-screen-handler-api-v1 1.3.30+1802ada577
       |-- fabric-sound-api-v1 1.0.13+1802ada577
       |-- fabric-transfer-api-v1 3.3.5+8dd72ea377
       \-- fabric-transitive-access-wideners-v1 4.3.1+1802ada577
    - fabricloader 0.16.0
       \-- mixinextras 0.4.0
    - farmersdelight 1.20.1-2.1.2+refabricated
       |-- mm 2.3
       |-- porting_lib_accessors 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_base 2.3.4+1.20.1
       |    |-- com_electronwill_night-config_core 3.6.6
       |    |-- com_electronwill_night-config_toml 3.6.6
       |    |-- porting_lib_attributes 2.3.4+1.20.1
       |    |-- porting_lib_common 2.3.4+1.20.1
       |    |-- porting_lib_core 2.3.4+1.20.1
       |    |-- porting_lib_entity 2.3.4+1.20.1
       |    |-- porting_lib_fluids 2.3.4+1.20.1
       |    |-- porting_lib_mixin_extensions 2.3.4+1.20.1
       |    |-- porting_lib_transfer 2.3.4+1.20.1
       |    |-- porting_lib_utility 2.3.4+1.20.1
       |    \-- reach-entity-attributes 2.4.0
       |-- porting_lib_client_events 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_config 2.3.4+1.20.1
       |    |-- com_electronwill_night-config_core 3.6.6
       |    |-- com_electronwill_night-config_toml 3.6.6
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_extensions 2.3.4+1.20.1
       |    |-- porting_lib_attributes 2.3.4+1.20.1
       |    |-- porting_lib_common 2.3.4+1.20.1
       |    |-- porting_lib_core 2.3.4+1.20.1
       |    \-- reach-entity-attributes 2.4.0
       |-- porting_lib_lazy_registration 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_loot 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_networking 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_recipe_book_categories 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_registries 2.3.4+1.20.1
       |    \-- porting_lib_core 2.3.4+1.20.1
       |-- porting_lib_tags 3.0
       |    \-- porting_lib_core 2.3.4+1.20.1
       \-- porting_lib_tool_actions 2.3.4+1.20.1
            \-- porting_lib_core 2.3.4+1.20.1
    - java 17
    - minecraft 1.20.1
    - sophisticatedbackpacks 3.19.5+mc1.20.1-SNAPSHOT-build.104
       |-- cardinal-components-base 5.2.2
       |-- cardinal-components-entity 5.2.2
       |-- forgeconfigapiport 8.0.0
       |-- porting_lib_model_loader 2.3.0+1.20.1
       \-- team_reborn_energy 3.0.0
    - sophisticatedcore 0.5.109+mc1.20.1-SNAPSHOT-build.104

I'm not a modder but I'm guessing it's linked to the fact that this mod uses tags to apply the status effects, and Sophisticated Backpacks isn't picking up on that.

AverageAnime commented 3 weeks ago

You are correct, this is due to how status effects are applied. There is a similar issue with Spice of Fabric mentioned here. I wasn't planning on doing anything when that issue came up, but now I am considering removing the tag status effect system. The customization added by the tags isn't very useful and doesn't seem worth the mod compatibility tradeoff. However, the compatibility issues are fairly small and I'd rather work on new content, so I don't know when I'll get around to it.