Compressor cannot handle large graphs

Avi-Levi / kryo

Automatically exported from code.google.com/p/kryo

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Compressor cannot handle large graphs #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Compressor only uses a short to store the length of the compressed data (lines 
78 and 91).  This cannot be easily changed by subclasses either, since the 
length is written in the parent class.

I altered Compressor to use int, and was able to successfully retrieve my data.

Original issue reported on code.google.com by fang...@gmail.com on 8 Sep 2011 at 2:44

GoogleCodeExporter commented 9 years ago

You could use packed Int to write buffer size. This way it would not consume 
extra bytes for int, but could scale up.

Original comment by kja...@gmail.com on 28 Sep 2011 at 11:45

GoogleCodeExporter commented 9 years ago

Original comment by nathan.s...@gmail.com on 29 Mar 2012 at 6:28

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Compressor is gone in v2. Compression of only some of the objects in a graph is 
done via a serializer that wraps another serializer. Eg, DeflateSerializer and 
BlowfishSerializer. These use chunked encoding and don't have a problem with 
using a 2 byte length.

Original comment by nathan.s...@gmail.com on 17 Apr 2012 at 10:24

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Issue 51 has been merged into this issue.

Original comment by nathan.s...@gmail.com on 17 Apr 2012 at 10:25