search

AviKKi / hover-preview

A vanilla js library to show preview images on hover
7 stars 17 forks source link

Add code linter and precommit hooks #4

Closed AviKKi closed 4 years ago

AviKKi commented 4 years ago
Bhavesh27 commented 4 years ago

@AviKKi Can you please assign me the issue. I can work on it.

baycak commented 4 years ago

Hi, I'd would like to work on this issue

Bhavesh27 commented 4 years ago

@AviKKi https://github.com/AviKKi/hover-preview/pull/6 Added husky for precommit hook and setup eslint.

AviKKi commented 4 years ago

@bayucakra20 seems like @Bhavesh27 has already made a PR, there seems to be a bug in the code, can you work on this?

Bhavesh27 commented 4 years ago

@AviKKi Added lint:fix step and fixed all linting error as well.

Bhavesh27 commented 4 years ago

@AviKKi Done all the changes.