search

AviKKi / hover-preview

A vanilla js library to show preview images on hover
7 stars 17 forks source link

husky and eslint setup #6

Closed Bhavesh27 closed 4 years ago

AviKKi commented 4 years ago

@Bhavesh27 looks perfect, can you add a command, in package.json 's scripts - yarn lint; for eslint src/*.js --fix

AviKKi commented 4 years ago

This PR will create a bit of a mess, every other line seems to be changed by linter. Please change the linter configuration for no-semi colon and single quotes.

Then we'll be good to merge.

AviKKi commented 4 years ago

I think you should use 'semi': ['error', 'never'], in .eslintrc.js to remove the semi-colons instead of removing the rule. Souce.