Make readdir ordering deterministic

AvianFlu / ncp

Asynchronous recursive file copying with Node.js.

MIT License

680 stars 103 forks source link

Make readdir ordering deterministic #49

Open joliss opened 10 years ago

joliss commented 10 years ago

The .sort is extremely fast, and it cannot hurt to make things deterministic, to avoid flickering tests for instance.

This is borderline bikesheddy, but I noticed the readdir call without sort when I read the source. I like to protect all my readdir calls (as well as Object.keys and friends) with .sort to keep my libraries deterministic.

Please merge if you like, or close otherwise. :)

joliss commented 10 years ago

I think Travis is just having a hiccup, the test suite passes on Node 0.8.