AvianFlu / ncp

Asynchronous recursive file copying with Node.js.
MIT License
681 stars 103 forks source link

ncp 1.0.0 "into itself" checking fails legitimate copy requests #63

Closed danielbprice closed 10 years ago

danielbprice commented 10 years ago

Test case; previous version:

$ mkdir test-0.6.0
$ cd test-0.6.0/
$ npm install ncp@0.6.0
node_modules/.bin/ncp node_modules node_modules.backup
$ echo $?
0
$ ls
node_modules  node_modules.backup

Test case; 1.0.0:

$ mkdir test-1.0.0
$ cd test-1.0.0
$ npm install ncp@1.0.0
$ node_modules/.bin/ncp node_modules node_modules.backup
An error has occurred.
Error: can't copy `/aux0/dp/test-1.0.0/node_modules.backup` into `/aux0/dp/test-1.0.0/node_modules`  itself
    at Function.ncp (/aux0/dp/test-1.0.0/node_modules/ncp/lib/ncp.js:34:23)
    at Object.<anonymous> (/aux0/dp/test-1.0.0/node_modules/ncp/bin/ncp:33:5)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:902:3
$ echo $?
1

This is, for us, very severe.

AvianFlu commented 10 years ago

Reverted that feature and published as 1.0.1. Let me know if that fixes it.

danielbprice commented 10 years ago

Yes, that does the trick:

$ mkdir test-1.0.1
$ cd test-1.0.1
$ npm install ncp@1.0.1
$ node_modules/.bin/ncp  node_modules node_modules.backup
$ ls
node_modules  node_modules.backup

Thanks!