search

AvianFlu / ncp

Asynchronous recursive file copying with Node.js.
MIT License
680 stars 103 forks source link

fix onFile: removed cb call that have no sense #68

Open coderaiser opened 9 years ago

coderaiser commented 9 years ago

In function onFile if !modified callback called. modified is not declared in README.md. If we have a lot files (100, for example) because of this call running and finished has wrong values so:

  1. Callback could not be called (this could be never true if ((started === finished) && (running === 0))
  2. Callback could be called earlier then it should.

modified flag should be added to README.md I think or be deleted, because nobody knows about it.

stefanpenner commented 9 years ago

awesome, just came to this conclusion as well. @AvianFlu whats holding this up?