search

AvianFlu / ncp

Asynchronous recursive file copying with Node.js.
MIT License
681 stars 103 forks source link

Callback doesn't get called at all #98

Open hollowdoor opened 9 years ago

hollowdoor commented 9 years ago

While copying a folder I noticed the callback never gets called. I'm not getting errors, but I'd like to do work in that callback once ncp is done.

The copy does happen. Just no calling of the cb.

I have version 2.0.0, and node version v0.10.37

hollowdoor commented 9 years ago

Seems like the callback is working now. ncp is an odd duck. Can I expect that it will keep working? It's deep in a program I have that may, or may not call it. Maybe there wasn't anything to move. Sorry if that's true. Please let me know if my issue has no basis. :)

alexcroox commented 9 years ago

I have the same issue, moving the files works, but the callback is never fired so I've no idea if it finished.

hollowdoor commented 9 years ago

@alexcroox Maybe I was right then. Don't know why it suddenly works for me.

It said in the documentation that the callback was called when there's an error. That seems wrong. How can code continue when the move operation is done? I'll have to review my usage of ncp. I don't want to roll my own implementation.

ryansturmer commented 9 years ago

I am experiencing this as well.

jtremback commented 8 years ago

Me too. Switching over to something else.

jprichardson commented 8 years ago

My package fs-extra (https://www.npmjs.com/package/fs-extra) should be a drop in replacement.

jtremback commented 8 years ago

I used cpr

mbret commented 8 years ago

same problem, plugin unusable :/

AdeshAtole commented 6 years ago

Is this repo being maintained anymore?

alexcroox commented 6 years ago

Given the last modified time of the files in master and the 31 outstanding PRs, I'd say no.

The author hasn't done anything else on Github since 2015 also...