search

Aviana / LunaUnitFrames

Unit Frames for WoW Classic
247 stars 103 forks source link

Getting Lua Errors when ever aggro indicator is selected in highlight or squares #748

Closed vandabbin closed 4 years ago

vandabbin commented 4 years ago

Hi! I am currently getting lua errors when I attempt to enable aggro indicators on either the raid frames or main tank frame. it happens whether I select highlight on aggro or use the aggro square.

Swatter gives me this error: Date: 2020-09-05 04:04:23 ID: 1 Error occured in: Global Count: 1 Message: ...nterface\AddOns\LunaUnitFrames\modules\highlight.lua line 94: Usage: UnitThreatSituation("unit" [, "mob"]) Debug:

...nterface\AddOns\LunaUnitFrames\modules\highlight.lua:94: ?() LunaUnitFrames\modules\units.lua:33: FullUpdate() LunaUnitFrames\modules\movers.lua:173: LunaUnitFrames\modules\movers.lua:128 LunaUnitFrames\modules\movers.lua:232: Enable() LunaUnitFrames\modules\movers.lua:412: Update() LunaUnitFrames\LunaUnitFrames.lua:37: OnInitialize() LunaUnitFrames\LunaUnitFrames.lua:280: LunaUnitFrames\LunaUnitFrames.lua:278 Locals: (*temporary) = "maintank5"

AddOns: Swatter, v8.2.6511 (SwimmingSeadragon) LunaUnitFrames, v3051 Stubby, v8.2.6510 (SwimmingSeadragon) BlizRuntimeLib_enUS v1.13.5.11305 (ck=94)

Upon relaunching the game I am greeted with the error on login as well as this mess. (luna frames are unlocked) image

When I attempt to open the settings window for luna I am greeted with this error: Date: 2020-09-05 04:10:38 ID: 2 Error occured in: Global Count: 1 Message: ..\AddOns\LunaUnitFrames\LunaUnitFrames.lua line 269: LunaUnitFrames isn't registed with AceConfigRegistry, unable to open config Debug:

...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1861: Open() LunaUnitFrames\LunaUnitFrames.lua:269: ?() ..\FrameXML\ChatFrame.lua:4695: ChatEdit_ParseText() ..\FrameXML\ChatFrame.lua:4356: ChatEdit_SendText() ..\FrameXML\ChatFrame.lua:4392: ChatEdit_OnEnterPressed()

  [string "*:OnEnterPressed"]:1

Locals: (*temporary) = "LunaUnitFrames isn't registed with AceConfigRegistry, unable to open config"

AddOns: Swatter, v8.2.6511 (SwimmingSeadragon) LunaUnitFrames, v3051 Stubby, v8.2.6510 (SwimmingSeadragon) BlizRuntimeLib_enUS v1.13.5.11305 (ck=94)

If I delete the saved config in my savedvariables folder it gets rid of the error and allows me to setup luna with a new configuration however the moment i select aggro indicator in anyway the error comes back and breaks the configuration file.

I disabled all other addons to make sure it wasn't a conflict with another addon

vandabbin commented 4 years ago

Upon messing around with different settings and enabling and disabling different parts of the unit frames I have so far narrowed it down at least partially to the maintank frames. It seems like as soon as I enable maintank frames and unlock the frames to move it around everything goes out of wack

vandabbin commented 4 years ago

If I make sure maintank frames are disabled before unlocking the frames it doesn't seem to throw the error at me

vandabbin commented 4 years ago

Perhaps I have done something wrong but I made this change in the movers.lua file on my installation to see if it fixed the issue for me and I am still getting similar errors and broken frames that require a /reload to correct

Date: 2020-09-06 04:52:16 ID: 1 Error occured in: Global Count: 13 Message: ..\AddOns\LunaUnitFrames\modules\squares.lua line 170: Usage: UnitThreatSituation("unit" [, "mob"]) Debug:

LunaUnitFrames\modules\squares.lua:170: ?() LunaUnitFrames\modules\units.lua:33: FullUpdate() LunaUnitFrames\modules\units.lua:383: LunaUnitFrames\modules\units.lua:356

LunaUnitFrames\modules\movers.lua:262: Disable() LunaUnitFrames\modules\movers.lua:417: Update() LunaUnitFrames\modules\options.lua:3476: LunaUnitFrames\modules\options.lua:3476

...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:51: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49 ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:843: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664

...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:72: ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:70 ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:306: Fire() ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:68: ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57 Locals:

Date: 2020-09-06 06:05:37 ID: 2 Error occured in: Global Count: 15 Message: ...nterface\AddOns\LunaUnitFrames\modules\highlight.lua line 94: Usage: UnitThreatSituation("unit" [, "mob"]) Debug: (tail call): ?

...nterface\AddOns\LunaUnitFrames\modules\highlight.lua:94: ?() LunaUnitFrames\modules\units.lua:33: FullUpdate() LunaUnitFrames\modules\layout.lua:83: Reload() LunaUnitFrames\LunaUnitFrames.lua:62: ?() ...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119: ...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119

...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:29: ...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25 ...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:64: Fire() Atlas\Libs\AceDB-3.0\AceDB-3.0.lua:466: SetProfile() ...Ons\Atlas\Libs\AceDBOptions-3.0\AceDBOptions-3.0.lua:275: ...Ons\Atlas\Libs\AceDBOptions-3.0\AceDBOptions-3.0.lua:274

...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:51: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49 ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:838: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664

...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:72: ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:70 ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:306: Fire() ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:442: ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:433

...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:72: ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:70 ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:306: Fire() ...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:351: ...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341 Locals: None

Date: 2020-09-06 06:23:29 ID: 1 Error occured in: Global Count: 1 Message: ..\AddOns\LunaUnitFrames\modules\movers.lua line 300: attempt to index local 'frame' (a nil value) Debug: (tail call): ? LunaUnitFrames\modules\movers.lua:300: SetFrame() LunaUnitFrames\modules\options.lua:180: LunaUnitFrames\modules\options.lua:170

...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:51: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49 ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:843: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664

...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:72: ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:70 ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:306: Fire() ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:68: ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57 Locals: None

vandabbin commented 4 years ago

Here are some clips demonstrating the issue

This behavior is the same before and after making the change in movers.lua. I think this issue should be reopened.

https://www.youtube.com/watch?v=2dgKcXD5rIk

https://www.youtube.com/watch?v=c1s9VRDN2uk

vandabbin commented 4 years ago

I hate to be annoying like this but I am still getting an error referencing squares.lua

I am no longer getting the highlight.lua errors so that does seem to be fixed. I am trying to look through squares.lua to see if I can identify a way to fix it, but i don't know my way around the code in this like you do 😄

Date: 2020-09-06 06:59:53 ID: 1 Error occured in: Global Count: 15 Message: ..\AddOns\LunaUnitFrames\modules\squares.lua line 170: Usage: UnitThreatSituation("unit" [, "mob"]) Debug:

LunaUnitFrames\modules\squares.lua:170: ?() LunaUnitFrames\modules\units.lua:33: FullUpdate() LunaUnitFrames\modules\units.lua:383: LunaUnitFrames\modules\units.lua:356

LunaUnitFrames\modules\movers.lua:262: Disable() LunaUnitFrames\modules\movers.lua:417: Update() LunaUnitFrames\modules\options.lua:3476: LunaUnitFrames\modules\options.lua:3476

...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:51: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49 ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:843: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664

...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:72: ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:70 ...nterface\AddOns\Atlas\Libs\AceGUI-3.0\AceGUI-3.0.lua:306: Fire() ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:68: ...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57 Locals:

vandabbin commented 4 years ago

inserting the line:

if not UnitExists(frame.unit) then return end

at line 170 in squares.lua fixed the error for me

Edit: Actually after looking through the code in the repo it appears the most up to date version would have the line being inserted at line 200

vandabbin commented 4 years ago

:heart: