search

AvidlyWordPress / zf-theme

A theme based on Foundation 6 by Zurb and the _s theme by Automattic
12 stars 2 forks source link

JavaScript order in config.yml #11

Closed pablopaul closed 6 years ago

pablopaul commented 6 years ago

It can be the case that particular Foundation libraries are not included in the right order in the config.yaml since it seems like the order in the zf-theme config is made up from alphabetical order which does not necessarily fulfill dependency needs from a any used Foundation library. You can find the dependencies for each Foundation JS library on the according doc page and then you can check the order in the config.yml. Dependencies must be loaded before the library loads which needs the dependency. Issue originally came up here https://github.com/zurb/foundation-sites/issues/10502

danielck commented 6 years ago

@pablopaul So is this still an issue or was the real issue #10 ?

pablopaul commented 6 years ago

@danielck it could be still in issue for other components which has different/other dependencies then Magellan.

danielck commented 6 years ago

This should no longer be an issue since I've updated the theme to use the webpack config from upstream, so dependencies should be properly fulfilled.