Avimitin / sdwm

Another dwm build, for more simplicity.
MIT License
25 stars 1 forks source link

Annoying tab bar color #4

Open Avimitin opened 3 years ago

Avimitin commented 3 years ago

After patching the tab, there is a bug that draws tab color to the bar.

image

I don't know which part of the code goes wrong.

Avimitin commented 3 years ago

So seems like it draws the tab at the bottom although I am not using monocle layout.

image

Avimitin commented 3 years ago

Current workaround: use the same color and transparency for bar and tab.

Avimitin commented 3 years ago

image

Current workaround: use the same color and transparency for bar and tab.

Seems like not work around now.

siduck commented 3 years ago

@Avimitin have titles disabled on the dwmbar , do you have the same?

Avimitin commented 3 years ago

@Avimitin have titles disabled on the dwmbar , do you have the same?

Yes, the titles are disabled.

siduck commented 3 years ago

oh , I have the same issue xD

siduck commented 3 years ago

but since I use same color for both tabbar and dwmbar so not a big deal

image image

siduck commented 3 years ago

idk why it still draws the title bg color on dwm bar even if i removed the title from it

Avimitin commented 3 years ago

idk why it still draws the title bg color on dwm bar even if i removed the title from it

I have an idea, maybe this patch helps: https://dwm.suckless.org/patches/colorbar/.

siduck commented 3 years ago

idk why it still draws the title bg color on dwm bar even if i removed the title from it

I have an idea, maybe this patch helps: https://dwm.suckless.org/patches/colorbar/.

looks cool , we just need to add the part for adding color to schemenorm from it

Avimitin commented 3 years ago

idk why it still draws the title bg color on dwm bar even if i removed the title from it

I have an idea, maybe this patch helps: https://dwm.suckless.org/patches/colorbar/.

looks cool , we just need to add the part for adding color to schemenorm from it

Seems like the error is not the same, I am still getting a piece of the tab bar color.

image

siduck commented 3 years ago

dang D:

Avimitin commented 3 years ago

dang D:

image

I've tried your chadwm and everything works well. So there is something different between our codes. Besides, your systray icon looks ok, and mine seems too large.

Avimitin commented 3 years ago

image

I can confirm that the tab was drawn to the bottom bar. Even I am using the tile layout.

siduck commented 3 years ago

weird

siduck commented 3 years ago

i get tabbar only in monocle

Avimitin commented 3 years ago

image

After commenting out the draw status code, the tab content disappear! So maybe the bug is came from here.

siduck commented 3 years ago

image

After commenting out the draw status code, the tab content disappear! So maybe the bug is came from here.

does that have any affect on the tabbar ( in tabbed mode )?

Avimitin commented 3 years ago

image After commenting out the draw status code, the tab content disappear! So maybe the bug is came from here.

does that have any affect on the tabbar ( in tabbed mode )?

No, and also I found out which part of code affect:

image

The tab is now drawing to the right of the status bar!

siduck commented 3 years ago

damn :0

Avimitin commented 3 years ago

Update: If I commented drw_rect function, the bar will disappear immediately.

image

But the tab will be mess up.

Avimitin commented 3 years ago

And if I changed the parameters inside drawstatusbar() function, the tab will be drawn like below:

image

So the tab place is controlled by the x and y parameter in function drw_rect

siduck commented 3 years ago

hmm , Idk much about these patches . My friend has made this patch.

Avimitin commented 3 years ago

hmm , Idk much about these patches . My friend has made this patch.

Alright, that's OK, I will try to figure out what happened. Currently, I use status text to overwrite it, so it looks slim and not so disgusting now. I'll try to fix it someday. Time for other works. ;)

image

Avimitin commented 3 years ago

Current workaround: https://github.com/Avimitin/sdwm/commit/af0cf723a3c2453a887f978c90a74374a29498b4

Now the tab window will only be cleaned in monocle layout or use tab configuration is enabled. The annoying color will still be there when using the monocle layout. But it never appears in other layouts.

I got other stuff to do, so this issue will temporarily have no update.