AvinZarlez / processing-vscode

A Visual Studio Code extension for the programming language Processing
https://marketplace.visualstudio.com/items?itemName=Tobiah.language-pde
MIT License
177 stars 25 forks source link

[FEATURE] Update default task file/readme about default shell #69

Closed AvinZarlez closed 4 years ago

AvinZarlez commented 5 years ago

Is your feature request related to a problem? Please describe. Some users are having issues with Windows using Bash. It's likely some kind of file name/directory path issue?

Describe the solution you'd like Ideally, I'd want Processing to run in the shell of the user's choice. But I guess since there is syntax differences between cmd and bash that may be causing an issue?

Some users have fixed themselves. Maybe rather than changing the task file, can update the readme for users to tweak themselves if its an issue?

Describe alternatives you've considered If I had the time I'd try to test out these cases and explore why bash may be failing, and see if I can make the script more robust to work regardless of shell used (rather than forcing it to summon cmd.exe)

Additional context The issue was first raised in #56 by @WissenIstNacht and @micuat

AvinZarlez commented 5 years ago

Updated Readme in 1.4

micuat commented 5 years ago

after some search, this worked on my Windows 10 / bash (reference: https://github.com/Microsoft/vscode/issues/46567) both strong and weak quote works, but escape doesn't.

{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "Run Sketch",
      "type": "shell",
      "group": {
        "kind": "build",
        "isDefault": true
      },
      "command": "${config:processing.path}",
      "presentation": {
        "echo": true,
        "reveal": "always",
        "focus": false,
        "panel": "dedicated"
      },
      "args": [
        "--force",
        {
          "value": "--sketch=${workspaceRoot}",
          "quoting": "strong"
        },
        {
          "value": "--output=${workspaceRoot}\\out",
          "quoting": "strong"
        },
        "--run"
      ]
    }
  ]
}
AvinZarlez commented 5 years ago

Ooh, great find!

I'll test it out and implement it in the next update.

(I'll need to make sure I still respect the Windows args though, because of the slash vs double slash should still be an issue mac vs. windows)

Though they're also the issue of updating the json and educating people to delete it and start over. Hopefully people having this issue will be able to figure that out.

AvinZarlez commented 4 years ago

Implemented in 1.4.1