search

AvitalTamir / cyphernetes

A Kubernetes Query Language
https://cyphernet.es
Apache License 2.0
527 stars 12 forks source link

feat: support dry run flag #145

Open naorpeled opened 2 weeks ago

naorpeled commented 2 weeks ago

closes #125

creation:

image

deletion:

image

patching:

image
naorpeled commented 2 weeks ago

@AvitalTamir wdyt about the output?

this is still a WIP, just wondering if it's a good direction

naorpeled commented 2 weeks ago

@AvitalTamir where should I add tests for this functionality? Also, what do you think about the new message format?

AvitalTamir commented 2 weeks ago

Hey @naorpeled looking good! Tests should go in k8s_query_test I think.

Re. Output I think we can compact it by only printing "Dry run, skipping changes:" Once at the top, right after query execution starts. Then per change only print a tiny header/tag like [DELETE] <resourceName> or something along those lines.