Closed narrucmot closed 3 years ago
Fixed.
Will scrub the non-xbzu1 scripts for create_hier_cell_interrupt_concat on the 2021.1 branch.
--Tom
From: tnizan-witekio @.> Sent: Tuesday, October 26, 2021 1:09 PM To: Avnet/hdl @.> Cc: Curran, Tom (EM) @.>; Author @.> Subject: [External] Re: [Avnet/hdl] Tc dev new xbzu1 (PR #25)
@tnizan-witekio commented on this pull request.
In boards/xbzu1_sbc/valtest/xbzu1_sbc_valtest.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736739649:
+# Target Devices: Xilinx Zynq UltraScale+ 3EG
+# Hardware Boards: Ultra96v2 Board
+#
+# ----------------------------------------------------------------------------
+
+proc avnet_create_project {project projects_folder scriptdir} {
+}
+proc avnet_import_constraints {boards_folder board project} {
+proc create_hier_cell_interrupt_concat { parentCell nameHier } {
I just realized that in each design we are defining create_hier_cell_interrupt_concat but we are not using it anymore.
Could be good to remove all of them at some point
In scripts/make_xbzu1_sbc_dualcam.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736751921:
+# Copyright(c) 2021 Avnet, Inc.
+# All rights reserved.
+# Create Date: Oct 05, 2021
+# Design Name: XBoard-ZU1 Dual Camera SYZYGY HW Platform
+# Module Name: make_xbzu1_sbc_dualcam.tcl
+# Project Name: XBoard-ZU1 Dual Camera SYZYGY HW
+# Target Devices: Xilinx Zynq UltraScale+ 1CG
+# Hardware Boards: Xboard-ZU1 Board + SYZYGY DualCam Pod
+if {$argc != 0} {
should be dualcam hw platform
In scripts/make_xbzu1_sbc_dualcam.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736751985:
set argv [list board=[lindex $argv 0] project=[lindex $argv 1] sdk=no close_project=yes dev_arch=zynqmp]
set argc [llength $argv]
source ./make.tcl -notrace
+} else {
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Avnet/hdl/pull/25#pullrequestreview-789670387, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCNSOD3UE3WAHSX4ST32CLUI3ODJANCNFSM5GWBX5DA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Fixed.
Will scrub the non-xbzu1 scripts for create_hier_cell_interrupt_concat on the 2021.1 branch.
--Tom
From: tnizan-witekio @.> Sent: Tuesday, October 26, 2021 1:09 PM To: Avnet/hdl @.> Cc: Curran, Tom (EM) @.>; Author @.> Subject: [External] Re: [Avnet/hdl] Tc dev new xbzu1 (PR #25)
@tnizan-witekio commented on this pull request.
In boards/xbzu1_sbc/valtest/xbzu1_sbc_valtest.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736739649:
+# Hardware Boards: Ultra96v2 Board
+#
+# ----------------------------------------------------------------------------
+
+proc avnet_create_project {project projects_folder scriptdir} {
+
+}
+
+proc avnet_import_constraints {boards_folder board project} {
+
+}
+
+proc create_hier_cell_interrupt_concat { parentCell nameHier } {
I just realized that in each design we are defining create_hier_cell_interrupt_concat but we are not using it anymore.
Could be good to remove all of them at some point
In scripts/make_xbzu1_sbc_dualcam.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736751921:
+# All rights reserved.
+#
+# ----------------------------------------------------------------------------
+#
+# Create Date: Oct 05, 2021
+# Design Name: XBoard-ZU1 Dual Camera SYZYGY HW Platform
+# Module Name: make_xbzu1_sbc_dualcam.tcl
+# Project Name: XBoard-ZU1 Dual Camera SYZYGY HW
+# Target Devices: Xilinx Zynq UltraScale+ 1CG
+# Hardware Boards: Xboard-ZU1 Board + SYZYGY DualCam Pod
+#
+# ----------------------------------------------------------------------------
+
+if {$argc != 0} {
Build valtest hw platform
should be dualcam hw platform
In scripts/make_xbzu1_sbc_dualcam.tclhttps://github.com/Avnet/hdl/pull/25#discussion_r736751985:
+# Design Name: XBoard-ZU1 Dual Camera SYZYGY HW Platform
+# Module Name: make_xbzu1_sbc_dualcam.tcl
+# Project Name: XBoard-ZU1 Dual Camera SYZYGY HW
+# Target Devices: Xilinx Zynq UltraScale+ 1CG
+# Hardware Boards: Xboard-ZU1 Board + SYZYGY DualCam Pod
+#
+# ----------------------------------------------------------------------------
+
+if {$argc != 0} {
Build valtest hw platform
set argv [list board=[lindex $argv 0] project=[lindex $argv 1] sdk=no close_project=yes dev_arch=zynqmp]
set argc [llength $argv]
source ./make.tcl -notrace
+} else {
Build valtest hw platform
should be dualcam hw platform
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Avnet/hdl/pull/25#pullrequestreview-789670387, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCNSOD3UE3WAHSX4ST32CLUI3ODJANCNFSM5GWBX5DA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.