search

Avnu / OpenAvnu

OpenAvnu - an Avnu sponsored repository for Time Sensitive Network (TSN and AVB) technology
468 stars 288 forks source link

Cpputest: Parse msrp PDUs #117

Open davidcemin opened 9 years ago

pinealservo commented 9 years ago

Was this really meant to be a bug, or an enhancement to the test suite?

andrew-elder commented 9 years ago

I think an enhancement. I've updated the tags.

pinealservo commented 9 years ago

OK, thanks for clarifying. Can you think of additional MSRP PDU tests to include aside from the ones I already added in open-avb-next? I tried to be comprehensive, but I may have missed some.

andrew-elder commented 9 years ago

Do we test multiple numValues decoding? ie Where first value in incremented to create additional attributes.

andrew-elder commented 9 years ago

Also, I think protocol version testing should pass as it is part of AVnu testing.

pinealservo commented 9 years ago

We're definitely testing muliple numValues; I based many of the test packets on some real-world packets, and there was a lot of numValues usage there.

Apparently I left a note to myself in the comments about protocol version testing, so I guess there's that left to do.