search

Avnu / OpenAvnu

OpenAvnu - an Avnu sponsored repository for Time Sensitive Network (TSN and AVB) technology
464 stars 289 forks source link

added library to play audio at a requested time #793

Closed bjklemme-intel closed 6 years ago

bjklemme-intel commented 6 years ago

Hi,

I worked with Chris Hall at Intel to create this library that allows a user to play an audio file with alsa at a specific requested time. It is intended to work with the daemon_cl that synchronizes time between computers.

If you have any questions please contact me at beverly.klemme@intel.com.

Thank you very much for your attention to this request, Beverly

pinealservo commented 6 years ago

Hi Beverly,

Thanks for the pull request! This looks like very interesting work, but it will take me a bit of time to look through it all and give some full feedback.

One thing I noticed up front, though, is that you've made the pull request against the master branch; we use that as our more "stable" branch, and we usually bring new work into the "open-avb-next" branch. Could you close this and open a pull request against "open-avb-next"? We'll take a closer look from there, but since it's largely a separate example application I don't think there will be any trouble getting it merged.

bjklemme-intel commented 6 years ago

Hi,

Thanks for the feedback!

Actually, I am sure I had pulled down the open-avb-next repo and had the Github set to that when I did the pull request. So I meant to do it correctly but (as I am sure you guessed ☺ ) I am a bit new to this. I will do some research to see where things went wrong…

Beverly

From: noreply@github.com [mailto:noreply@github.com] Sent: Tuesday, June 12, 2018 8:19 AM To: AVnu/OpenAvnu OpenAvnu@noreply.github.com Cc: Klemme, Beverly beverly.klemme@intel.com; Author author@noreply.github.com Subject: Re: [AVnu/OpenAvnu] added library to play audio at a requested time (#793)

Hi Beverly,

Thanks for the pull request! This looks like very interesting work, but it will take me a bit of time to look through it all and give some full feedback.

One thing I noticed up front, though, is that you've made the pull request against the master branch; we use that as our more "stable" branch, and we usually bring new work into the "open-avb-next" branch. Could you close this and open a pull request against "open-avb-next"? We'll take a closer look from there, but since it's largely a separate example application I don't think there will be any trouble getting it merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AVnu/OpenAvnu/pull/793#issuecomment-396628001, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7g6o8eRUmQsHQXlwr3zOAaBncUBEJJks5t79vTgaJpZM4UjScR.

pinealservo commented 6 years ago

No worries, it happens by accident all the time even to people who are fairly experienced with it. Having a non-master development branch is unusual on github, so the default workflow isn't really designed for it.

pinealservo commented 6 years ago

One more thing I noticed just looking through the changes--you seem to have captured some binary files and other build products (the pycache directory, etc.) that you may not have intended. It would be best to remove those from the commit before the next pull request.

bjklemme-intel commented 6 years ago

Oh WOW! Something went more wrong than I thought…

Thanks, Beverly

From: noreply@github.com [mailto:noreply@github.com] Sent: Tuesday, June 12, 2018 10:33 AM To: AVnu/OpenAvnu OpenAvnu@noreply.github.com Cc: Klemme, Beverly beverly.klemme@intel.com; Author author@noreply.github.com Subject: Re: [AVnu/OpenAvnu] added library to play audio at a requested time (#793)

One more thing I noticed just looking through the changes--you seem to have captured some binary files and other build products (the pycache directory, etc.) that you may not have intended. It would be best to remove those from the commit before the next pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AVnu/OpenAvnu/pull/793#issuecomment-396671632, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7g6rizOOzW2qN5cxyklqaE4xRjvIJoks5t7_s2gaJpZM4UjScR.

bjklemme-intel commented 6 years ago

Hi,

I don’t know how those files got mixed up in there but I did git rm and a new commit. I think what went wrong with the pull request branch is that I did the pull request from the open-avb-next branch but then it gets me to another screen that defaults to master. Hopefully, I requested it correctly this time.

I have submitted a new pull request. Hopefully, everything is in order. If not, I will solicit some internal help to be sure I get it right next time.

Thanks, Beverly

From: noreply@github.com [mailto:noreply@github.com] Sent: Tuesday, June 12, 2018 10:33 AM To: AVnu/OpenAvnu OpenAvnu@noreply.github.com Cc: Klemme, Beverly beverly.klemme@intel.com; Author author@noreply.github.com Subject: Re: [AVnu/OpenAvnu] added library to play audio at a requested time (#793)

One more thing I noticed just looking through the changes--you seem to have captured some binary files and other build products (the pycache directory, etc.) that you may not have intended. It would be best to remove those from the commit before the next pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AVnu/OpenAvnu/pull/793#issuecomment-396671632, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7g6rizOOzW2qN5cxyklqaE4xRjvIJoks5t7_s2gaJpZM4UjScR.

andrew-elder commented 6 years ago

@bjklemme-intel - I should "close" this pull request, correct? You have a new one.

You can go ahead and just select the "Close and comment" button yourself to close it if you like. You should have permission to close your own pull request.

bjklemme-intel commented 6 years ago

Done! B

From: andrew-elder [mailto:notifications@github.com] Sent: Wednesday, June 13, 2018 5:12 AM To: AVnu/OpenAvnu OpenAvnu@noreply.github.com Cc: Klemme, Beverly beverly.klemme@intel.com; Mention mention@noreply.github.com Subject: Re: [AVnu/OpenAvnu] added library to play audio at a requested time (#793)

@bjklemme-intelhttps://github.com/bjklemme-intel - I should "close" this pull request, correct? You have a new one.

You can go ahead and just select the "Close and comment" button yourself to close it if you like. You should have permission to close your own pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/AVnu/OpenAvnu/pull/793#issuecomment-396915522, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ah7g6m_O8AajG2Ty-Xin3vd26zIzaAdHks5t8QGPgaJpZM4UjScR.