Aquantia NIC support - Githubissues

Avnu / OpenAvnu

OpenAvnu - an Avnu sponsored repository for Time Sensitive Network (TSN and AVB) technology

467 stars 288 forks source link

Aquantia NIC support #887

Closed Egor-Pomozov-AQ closed 4 years ago

Egor-Pomozov-AQ commented 4 years ago

Add atl_avb submodule
Update Makefiles, .cmake and CMakeList.txt to support a building of Aquantia hardware support
Add atl lib support to common lib
Add atl_simple_talker example
Add asyncronous storing to pcap file in example applications
Add send_packet_precisely example application
Add run_atl.sh file to simple installation of atl_tsn driver
Add atl hardware support in avtp_pipeline:
- Create new atl_rawsock
- Create new scheme of launchtime calculation
- Add support for non-compressed audio streams
- Update logging system to support a log from hardware library
Apply fix for AVB class support issue in mrp_client.c

Important note: this request doesn't contain support for compressed streams. If somebody needs a support of compressed streams let's discuss it in comments.

andrew-elder commented 4 years ago

Is anyone with an i210 setup up and running able to test this pull request for side effects?

Jtun53 commented 4 years ago

Is anyone with an i210 setup up and running able to test this pull request for side effects?

We've gathered results with i210 + 8M MOTU device using AVnu/OpenAvnu master branch and avtp_pipeline example with different combinations of the following parameters:

IGB_LAUNCHTIME_ENABLED
Master/Slave configurations
tx_blocking_in_intf in example_talker.ini
1 talker vs 2 talker streams

Results obtained with branch aq_atl_hw_support were identical. Our current changes shouldn't affect any of the new code in open_avb_next branch.

andrew-elder commented 4 years ago

@Jtun53 - thanks for that update.

andrew-elder commented 4 years ago

Does anyone have any comments on this pull request?

aguedes commented 4 years ago

Nice to see another TSN/AVB capable hardware being enabled!

@Egor-Pomozov-AQ, from the examples in this PR I could see some code to reserve bandwidth and configure launch time. Does the NIC support these features in hardware? If so, do you guys plan to also enable them in upstream atlantic driver, integrating with cbs and etf qdiscs?

andrew-elder commented 4 years ago

@aguedes - do you have any other comments? The PR looks good to me!

Egor-Pomozov-AQ commented 4 years ago

Nice to see another TSN/AVB capable hardware being enabled!

@Egor-Pomozov-AQ, from the examples in this PR I could see some code to reserve bandwidth and configure launch time. Does the NIC support these features in hardware? If so, do you guys plan to also enable them in upstream atlantic driver, integrating with cbs and etf qdiscs?

Andre, there is a product AQC107 on a market where scheduled DMA is supported by Firmware. Also we are preparing new solution where this feature is implemented in a hardware.

We are investigating a possibility to add launchtime feature in an upstream driver.

aguedes commented 4 years ago

@aguedes - do you have any other comments? The PR looks good to me!

Nope, I don't have any comments. BTW, I just took a look on the examples files.

aguedes commented 4 years ago

Andre, there is a product AQC107 on a market where scheduled DMA is supported by Firmware. Also we are preparing new solution where this feature is implemented in a hardware.

We are investigating a possibility to add launchtime feature in an upstream driver.

Great, thanks for the info.

andrew-elder commented 4 years ago

Ok, I'm merging this one. I don't see any negative feedback. @Egor-Pomozov-AQ, thank you very much for this patch!