Atl mode should not be default

Avnu / OpenAvnu

OpenAvnu - an Avnu sponsored repository for Time Sensitive Network (TSN and AVB) technology

462 stars 289 forks source link

Atl mode should not be default #914

Closed MarcinMiklas closed 3 years ago

andrew-elder commented 3 years ago

What is ATL? Anyone have objections to this MR?

MarcinMiklas commented 3 years ago

ATL is part of Aquantia NIC support added in: https://github.com/Avnu/OpenAvnu/pull/885 https://github.com/Avnu/OpenAvnu/pull/887

Current cmake/makefiles are pretty messy. It would be good to rewrite them from ground up and make nice cmake configuration/feature options to easily choose what hardware support you want and what sw features you choose. But this is topic for another big PR. Here I am just restoring the linux generic as default compilation option, if no special flags are defined.

bdthomsen commented 3 years ago

Changes look reasonable to me.