Installed header files should have C++ guards

Avnu / libavtp

Open source implementation of Audio Video Transport Protocol (AVTP) specified in IEEE 1722-2016 spec.

BSD 3-Clause "New" or "Revised" License

62 stars 34 forks source link

Installed header files should have C++ guards #8

Closed thiagomacieira closed 5 years ago

thiagomacieira commented 6 years ago

They're missing:

#ifdef __cplusplus
extern "C" {
#endif
....
#ifdef __cplusplus
}
#endif

So C++ source code can #include the headers.

andrew-elder commented 6 years ago

@thiagomacieira - thanks for the comments. Feel free to create a pull request with the changes you would like to see applied. I'm uncertain whether this repo is supposed to be "pure" C, or not. Comments anyone?

aguedes commented 6 years ago

Yes, this makes sense to me. I can fix it if @thiagomacieira isn't willing to.

aguedes commented 6 years ago

@thiagomacieira, PR https://github.com/AVnu/libavtp/pull/10 fixes this issue (PR merged already, by the way) so I believe we can close this issue.