search

Avocarrot / json2view

Update native Android UI on the fly
MIT License
1.51k stars 279 forks source link

Support GridView's numColumn property and applyVisibility #29

Closed BrandonTsai closed 7 years ago

BrandonTsai commented 7 years ago

Also support get ids by DynamicView.getIdMap(); Therefore, user can get child view by findViewById(idMap.get("id_name").intValue());

tsiougkosn commented 7 years ago

Hi there,

It seems that some tests are failing due to your changes in the pull request. Could you check on it ?

BrandonTsai commented 7 years ago

Hi,

I have committed the fix. Thanks.

tsiougkosn commented 7 years ago

Hi there,

Thanks for checking and fix the failing test. I have a comment. Please check it out.

Also it would be better to make a Pull Request per feature, eg you PR can be split in four PRs, one for changes in visibility, an other one for numColumns of GridView and the other two for ids and background.

tsiougkosn commented 7 years ago

The PR is split by @BrandonTsai. so closing