Add automated contributors #70

Avogadro / two.avogadro.cc

Documentation and development website for Avogadro2

https://two.avogadro.cc/

BSD 3-Clause "New" or "Revised" License

7 stars 30 forks source link

Add automated contributors #70 #83

Open ASK-03 opened 8 months ago

ASK-03 commented 8 months ago

This PR solves Issue #70

This PR is an extension of PR #73 and preserves the commits of the previous contributor

Changes:

[x] Add GITHUB_TOKEN using environment variable
[x] Removed cryos/avogadro from repositories variable as it has been closed
[x] Removed the code that updates credits.md as it is handled by Sphinx
[x] Added code block to add full name of the contributor if its is not available then the username is used
[x] Removed the sort as it was doing nothing.

ASK-03 commented 8 months ago

@ghutchis, I have done the necessary changes. Please have a look.

ghutchis commented 8 months ago

It looks good although the downside is that the rest of the contributors list is sorted, and the new contributors are added to the end. I think it would be better to insert in sorted order or re-sort after adding the new contributor.

ASK-03 commented 8 months ago

It looks good although the downside is that the rest of the contributors list is sorted, and the new contributors are added to the end. I think it would be better to insert in sorted order or re-sort after adding the new contributor.

Sure, I will add the changes. Could you please clarify if you prefer sort based on chronological order of first contribution or lexicographical sort would be suitable?

ghutchis commented 8 months ago

We have gone with lexicographical sort, thanks.

ASK-03 commented 8 months ago

@ghutchis. I have made the changes.