search

AvremelM / Userscripts

MIT License
9 stars 5 forks source link

Multiple Pause Buttons #3

Closed aurosharman closed 10 years ago

aurosharman commented 10 years ago

screen shot 2014-06-24 at 10 36 00 pm

This happened when I was given a speech prompt, and got the red "we couldn't understand you or you said it wrong" response. Each time that happened, an additional pause button was added. Only the last one went away when it finally understood me; the other two stuck around for the rest of the lesson, with a third one popping in and out in the normal fashion.

This is on MacOS 10.9.3, Firefox 30.0.

AvremelM commented 10 years ago

Ok, this is an interesting bug, thanks so much for reporting it!

This happens because Duo calls its graded() method multiple times on one problem, when my code assumed that it would only call it once (as on most problems).

Reproduced and then fixed in v0.2.3

I'm going to poke around a bit (I haven't looked at this code in months) to see if this might happen anywhere else, especially if Duo brings back retries.

aurosharman commented 10 years ago

Happy to help, I really like having the script. I participate in the discussions a lot, and it had really annoyed me, having to choose between timed practice (I need the push to translate faster, the slower pace is too easy) and being able to stop for a minute after answering a problem to think about its nuances.

Possibly dumb question: Do I need to remove the Lesson Review userscript and then resinstall it, in order to get the patch? I know there's a package of scripts that auto-updates, but I didn't really need the other features...

AvremelM commented 10 years ago

You shouldn't have to uninstall it first, but if you don't have auto-updating, you may have to manually reinstall it.

aurosharman commented 10 years ago

Cool. Re-installed, looked in the prefs, and it seems to have done the right thing of replacing the previous version. Thanks much. :-)

AvremelM commented 10 years ago

No problem, thanks again for reporting! Regarding the auto-updating version of the userscript, I just wanted to point out that any features/functions you don't want can be disabled in your account settings.

aurosharman commented 10 years ago

A follow-up on this -- the multiple pause is fixed, but the coloration of the box along the progress bar is wrong. I just had another encounter with a mic problem mishearing me the first time. After I got it right, it remained red in the progress bar.

Not a huge deal, but thought you might be interested to know, anyways...