search

AvtechScientific / ASL

Advanced Simulation Library - hardware accelerated multiphysics simulation platform.
http://asl.org.il
GNU Affero General Public License v3.0
217 stars 55 forks source link

Explicitly define namespace of ifstream and ofstream #18

Closed barthalion closed 8 years ago

barthalion commented 8 years ago

With GCC 5.3.0 and Boost 1.60.0, the build fails with following error: /build/libasl/src/ASL-0.1.6/src/utilities/aslParametersManager.cxx:466:6: error: reference to 'ifstream' is ambiguous ifstream ifs(p.string()); ^ /usr/include/boost/filesystem/fstream.hpp:169:32: note: candidates are: typedef class boost::filesystem::basic_ifstream boost::filesystem::ifstream typedef basic_ifstream ifstream; ^

AvtechScientific commented 8 years ago

Cześć Bartłomiej,

thank you very much for the patch. Could you, please, follow the steps outlined bellow so we can accept your PR and credit your contribution:

http://asl.org.il/copyright_assignment/

While it looks like a bureaucratic formality - it is the only mechanism we have to enforce AGPL and thus protect ASL (including your contributions) from being exploited. This needs to be done only once for the first pull request.

Welcome to the ASL community!

lupinix commented 8 years ago

Hi all,

I applied this patch in Fedora package as builds started to fail in our development tree too (same gcc and boost). Thank you very much :)

Greetings, Christian

AvtechScientific commented 8 years ago

@Barthalion,

could you, please, sign the doc and send us the photograph, so we can merge your PR and credit your contribution? As you see - people need it.

Thanks!

barthalion commented 8 years ago

@AvtechScientific,

thanks for the reminder – I just signed it and sent to you.

Thanks, Bartłomiej

AvtechScientific commented 8 years ago

Great! Any further contributions (which are more than welcome :) ) can be made without any formalities.

Dziękuję Ci bardzo!