AvtechScientific / ASL

Advanced Simulation Library - hardware accelerated multiphysics simulation platform.
http://asl.org.il
GNU Affero General Public License v3.0
223 stars 55 forks source link

This library package calls exit() #4

Closed AvtechScientific closed 9 years ago

AvtechScientific commented 9 years ago

[ 258s] ASL.x86_64: W: shared-lib-calls-exit /usr/lib64/libaslCommon.so.0.1.2 exit@GLIBC_2.2.5 [ 258s] This library package calls exit() or _exit(), probably in a non-fork() [ 258s] context. Doing so from a library is strongly discouraged - when a library [ 258s] function calls exit(), it prevents the calling program from handling the [ 258s] error, reporting it to the user, closing files properly, and cleaning up any [ 258s] state that the program has. It is preferred for the library to return an [ 258s] actual error code and let the calling program decide how to handle the [ 258s] situation.

AvtechScientific commented 9 years ago

All remaining exit()'s in ApplicationParametersManager::load() are needed and this part of code is more an application in its nature than a library