search

AvtechScientific / ASL

Advanced Simulation Library - hardware accelerated multiphysics simulation platform.
http://asl.org.il
GNU Affero General Public License v3.0
217 stars 55 forks source link

Local CMakeParseArguments breaks with vtk 9.1 #48

Closed opoplawski closed 2 years ago

opoplawski commented 2 years ago

The inclusion of local CMakeParseArguments breaks with vtk 9.1:

CMake Error at /usr/lib64/cmake/vtk/vtkDetectLibraryType.cmake:23 (message):
  The `PATH` argument is required.
Call Stack (most recent call first):
  /usr/lib64/cmake/vtk/patches/99/FindHDF5.cmake:1066 (vtk_detect_library_type)
  /usr/lib64/cmake/vtk/VTK-vtk-module-find-packages.cmake:397 (find_package)
  /usr/lib64/cmake/vtk/vtk-config.cmake:150 (include)
  CMakeLists.txt:56 (find_package)

Which --trace indicates was triggered by the usage of the local CMakeParseArguments.cmake. I think it's time to require cmake 3.1 and drop the local FindOpenCL and deps.

AvtechScientific commented 2 years ago

Thank you very much! Do you mind to propose a PR?